Jennifer Pioch wrote:
[CC:'ing David Comay <David.Comay at sun.com> for the |libc::wordexp()|
item below...]
> On 11/29/08, April Chin <April.Chin at sun.com> wrote:
> > I am requesting code review of the update of ksh93 to
> > ksh93t 2008-11-04 for OpenSolaris contributor Roland Mainz
> > (roland.mainz at nrubsig.org).
> > We'd like to receive review comments by Friday, December 5.
> >
> > The review is broken into two parts.
> >
> > The webrev for the changes to the AT&T files for ksh93 and its libraries,
> > for the update to ast-base version 2008-11-04 is at:
> >
> > http://cr.opensolaris.org/~chin/ksh93-update1.ast
> >
> > The webrev for all of the other (non-AST) files, including Makefile
> > and packaging changes, is at:
> >
> > http://cr.opensolaris.org/~chin/ksh93-update1.non-ast
[snip]
> I've reviewed the previous webrevs and the changes look good to me.
Thanks !:-)
> Few questions out of curiosity:
> usr/src/lib/libast/common/llib-last
> Was this file build by hand or script?
Originally it was done by a script (with manual edits to get rid of
compiler problems which appeared after the switch to Studio 12 (once
this putback is done the compiler people may get a longer list of issues
(on the top are issues the non-optimized AMD64 debug code and the reason
why we have -_cc=-xcsi in the Makefiles, followed by "lint" problems)))
but later new entries were added by hand.
> usr/src/uts/common/exec/shbin/shbin.c
> What is the purpose of /sbin/ksh93?
The original request was to add /sbin/sh at the bottom of the search
list to allow compiled shell scripts to be used in OpenSolaris
distributions which use /sbin/sh==ksh93 with a split root+usr filesystem
layout. Since /sbin/sh may be either { original Bourne shell XOR ksh93 }
we used /sbin/ksh93 here to explicitly refer to ksh93 since the original
Bourne shell is highly allergic to compiled shell code. Originally we
thought we add a compile switch for this but this was later removed
because it adds lots of extra complexity in the Makeefiles and
OpenSolaris Indiana only uses "stock" Nevada binaries and doesn't even
use the existing build flags (e.g. I am still puzzled why Indiana
refuses to use the switch in
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/Makefile.ksh93switch
and instead uses the monster wrapper in
http://src.opensolaris.org/source/xref/pkg/gate/src/util/distro-import/ksh-wrapper.c).
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
