James Carlson wrote: > Roland Mainz writes: > > April Chin wrote: > > > > James Carlson wrote: > > > > > - No changes were made to these files: > > > > > $SRC/lib/libcmd/amd64/Makefile > > > > > $SRC/lib/libcmd/i386/Makefile > > > > > $SRC/lib/libcmd/sparc/Makefile > > > > > $SRC/lib/libcmd/sparcv9/Makefile > > > > > Don't deliver unchanged files. > > > > > > > > What do you mean ? > > > > > > Since the added line > > > SHELL=/usr/bin/ksh > > > was removed from these Makefiles and moved to > > > usr/src/lib/libcmd/Makefile.com, the only changes left are to the comments > > > (updated CDDL, copyright). So we should no longer be touching these > > > files. > > > > Why ? At least the "CDDL/copyright update job" would be done (e.g. it > > would save the work when someone crawls over the tree and does a general > > CDDL license template update) ... > > It's just not done. Call it a style thing or a C-team thing if you > like, but random changes in copyrights aren't normally acceptable.
Ok... this is different to Mozilla.org where you get sometimes review comments like "... ah, and when you do cleanup work update the MPL license template - it's the old version...". > If someone really thinks that these files need to change right now, > then please file a *separate* bug saying "update copyright on this > handful of files" and include that in the putback comments. It > doesn't seem like a worthwhile thing to do, but ... AFAIK it's only worthwhile when it can be done together with other cleanup work... a seperate putback extra for a mass-license template update work sounds weired... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;)
