Roland Mainz wrote:
> Garrett D'Amore wrote:
>
>> Garrett D'Amore wrote:
>>
> [snip]
>
>>> Roland Mainz wrote:
>>>
>>>> <NOTE>Please note the _timeout_ is set to 2008-08-25 since we don't have
>>>> much time left anymore, after that point the code will move to a
>>>> Mercurial tree for final review and integration.</NOTE>
>>>>
>>>> Here comes round "two" of the preliminary code review for the first
>>>> update of the ksh93 integration project: I created a webrevs based on
>>>> today's (2008-08-22) ksh93-integration
>>>> prototype012 Subversion tree which is based on the OS/Net Mercurial HEAD
>>>> version.
>>>>
>>>> The webrev can be found at
>>>> http://cr.opensolaris.org/~gisburn/ksh93_integration/ksh93_update1/webrev_20080821_001/
>>>>
> [snip]
>
>>>> - usr/src/cmd/nsadmin/ksh.kshrc contains a change which provides a
>>>> default "PS1" based on a similar prompt delivered by SuSE. The change
>>>> may be commented out in the final version to simplify the ARC case
>>>>
> [snip]
>
>> One more small note, which I forgot to add. Your change to the prompt
>> may be better run as a separate case/integration. Changes in default
>> environment settings (like the PS1 prompt) are the sort of things that
>> folks get emotional about, and I'd hate to see your larger body of work
>> get hamstrung by a bikeshed on the prompt.
>>
>
> The PS1 change has been ARC'ed&&approved, too (and it's the same as used
> in SuSE and OpenSolaris/Indiana 2008.05).
>
Ah, then its not a problem.
-- Garrett
> ----
>
> Bye,
> Roland
>
>
