Hi! ----
Here comes round "two": I created a couple of webrevs in various flavours based on today's (2007-02-02) ksh93-integration sources. This isn't the "preliminary review request" (yet), just another attempt to provide an updated webrev. Somehow I didn't had time to finish the review documentation yet but most of the issues listed by James Calson's have been addressed (please read http://mail.opensolaris.org/pipermail/ksh93-integration-discuss/2007-January/002137.html ; still waiting for a reply whether the changes are Ok or not), excluding the *.diff file (bickering in progress) and "wordexp.c" (fixes/comments for that follow later). ** Webrevs: * Webrev over all files: http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_integration_prototype004_webrev_20070202/allfiles/webrev/ * Webrev only over files which match the substring "makefile": http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_integration_prototype004_webrev_20070202/makefile_files/webrev/ * Webrev over all non-AST files (this includes the files in usr/src/cmd/ast/msgcc/ my accident): http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_integration_prototype004_webrev_20070202/non_ast_files/webrev/ * Webrev over all AST sources (e.g. all files not listed in the previous "webrev"): http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_integration_prototype004_webrev_20070202/non_files/webrev/ * All-in-one unified diff: http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_integration_prototype004_webrev_20070202/unified_diff.txt ** Notes: 1. [Same as the "Notes" in http://mail.opensolaris.org/pipermail/ksh93-integration-discuss/2007-January/002091.html] 2. I used the "webrev" script from b51's "SUNWonbld" package wrapped in http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_integration_prototype004_webrev_20070202/build_ksh93integration_webrev.ksh ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;)
