Hi Amit, I have looked into the modified files and I have several remarks. I propose to have a code review about the changes. Should I send them in email or maybe you prefer some discussion in a pull request (e.g. KDE Invent) ?
Best regards, Zoltan Zoltan Padrah <zoltan.pad...@gmail.com> ezt írta (időpont: 2023. máj. 24., Sze, 12:12): > > Hello Amit, > > thank you for the patch. I will look into it in the following days. > > Best regards, > > Zoltan > > Amit Pr <amitpra...@gmail.com> ezt írta (időpont: 2023. máj. 20., Szo, 8:59): > > > > Hi Zoltan, > > > > Thanks for your efforts in keeping ktechlab going > > > > I would like to offer a small patch for some of the issues I have fixed > > while using ktechlab with gpsim > > > > Thanks, > > Amit > > > > summary of patch (existing) > > > > GPsim performance fix - reduces cpu load when running processor simulation > > ./electronics/gpsimprocessor.cpp > > ./electronics/gpsimprocessor.h > > > > Support for pic12f675 > > ./micro/microlibrary.cpp > > ./micro/picinfo12bit.cpp > > ./micro/picinfo12bit.h > > > > Fix for Lamp not glowing > > ./electronics/components/ecsignallamp.cpp > > > > example for PIC12F675 (new files) > > > > ./examples/pic-12f675/12F675.circuit > > ./examples/pic-12f675/blink.asm > > ./examples/pic-12f675/blink.cod > > ./examples/pic-12f675/blink.hex > > ./examples/pic-12f675/blink.jal > > > > > > > > _______________________________________________ Ktechlab-devel mailing list Ktechlab-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ktechlab-devel
