Some small notes, just for reference. Yes, this is my patch, and with the notable exception of the (testing) changelog entry, the patch is up to date. Thank you for taking care of the paperwork and additional testing.
We could totally clean up the QtNetworkReply headers, either in this upload or the next one. The impact there is negligible, since this is the only usage of such headers. Also, this removes some MOCK_RELEASE functionality. This Is Fine, because the package has no autopkgtests (this was a pain to test manually, so I will be fixing this!) and as such, that conditional was only used for local testing. My patch doesn't have traction upstream yet, but besides $past_issues I don't see why they'd reject it: https://invent.kde.org/system/distro- release-notifier/-/merge_requests/6 Side note: I noticed only the C++11 standard is enforced, when all of KDE and Qt use C++17 (this is worth double checking). **This will cause issues when those libraries start using newer features.** (I dealt with this bug last cycle in LXQt.) Thanks. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to plasma-distro-release-notifier in Ubuntu. https://bugs.launchpad.net/bugs/2039492 Title: [SRU] plasma-distro-release-notifier gets EOL data from git.launchpad.net To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/plasma-distro-release-notifier/+bug/2039492/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
