Omer Akram has proposed merging 
lp:~om26er/kubuntu-packaging/qtmultimedia_unittests into 
lp:~kubuntu-packagers/kubuntu-packaging/qtmultimedia-opensource-src.

Commit message:
Run unittests during build, disable flaky tests

Requested reviews:
  Kubuntu Packagers (kubuntu-packagers)

For more details, see:
https://code.launchpad.net/~om26er/kubuntu-packaging/qtmultimedia_unittests/+merge/198387

Run unittests during build, disable flaky tests
-- 
https://code.launchpad.net/~om26er/kubuntu-packaging/qtmultimedia_unittests/+merge/198387
Your team Kubuntu Packagers is requested to review the proposed merge of 
lp:~om26er/kubuntu-packaging/qtmultimedia_unittests into 
lp:~kubuntu-packagers/kubuntu-packaging/qtmultimedia-opensource-src.
=== added directory 'debian/patches'
=== added file 'debian/patches/series'
--- debian/patches/series	1970-01-01 00:00:00 +0000
+++ debian/patches/series	2013-12-10 13:15:00 +0000
@@ -0,0 +1,1 @@
+skip_failing_tests.patch

=== added file 'debian/patches/skip_failing_tests.patch'
--- debian/patches/skip_failing_tests.patch	1970-01-01 00:00:00 +0000
+++ debian/patches/skip_failing_tests.patch	2013-12-10 13:15:00 +0000
@@ -0,0 +1,20 @@
+=== modified file 'tests/auto/unit/qmediaplaylist/tst_qmediaplaylist.cpp'
+--- a/tests/auto/unit/qmediaplaylist/tst_qmediaplaylist.cpp	2013-09-20 19:21:01 +0000
++++ b/tests/auto/unit/qmediaplaylist/tst_qmediaplaylist.cpp	2013-12-05 16:30:52 +0000
+@@ -341,6 +341,7 @@
+ 
+ void tst_QMediaPlaylist::saveAndLoad()
+ {
++    QSKIP("QTBUG-23826: Is flaky and has been like that for a while");
+     QMediaPlaylist playlist;
+     playlist.addMedia(content1);
+     playlist.addMedia(content2);
+@@ -649,6 +650,7 @@
+ 
+ void tst_QMediaPlaylist::testLoaded_signal()
+ {
++    QSKIP("QTBUG-35420 Is falky and fails at random");
+     //create an instance of QMediaPlaylist class.
+     QMediaPlaylist playlist;
+     playlist.addMedia(content1); //set the media to playlist
+

=== modified file 'debian/rules'
--- debian/rules	2013-11-14 06:29:52 +0000
+++ debian/rules	2013-12-10 13:15:00 +0000
@@ -7,6 +7,7 @@
 export CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) $(shell dpkg-buildflags --get CPPFLAGS)
 export LDFLAGS := $(shell dpkg-buildflags --get LDFLAGS) -Wl,--as-needed
 export QT_SELECT := qt5
+export QT_QPA_PLATFORM := minimal
 
 %:
 	dh $@ --parallel --with pkgkde_symbolshelper --dbg-package=qtmultimedia5-dbg
@@ -36,3 +37,7 @@
 override_dh_builddeb:
 	dh_builddeb -- -Zxz
 
+override_dh_auto_test:
+	export LD_LIBRARY_PATH=$(CURDIR)/lib
+	cd tests/auto/unit/ && ( test -e Makefile || qmake unit.pro -o Makefile ) && make -f Makefile check
+

-- 
kubuntu-devel mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel

Reply via email to