Hello everyone, I may have my first possible ABI break and I need some assistance determining this. Please be kind, I am still learning C++.
Missing symbol: #MISSING: 5.4.0# _ZN6Plasma6Applet16destroyedChangedEb@Base 5.3.0+git20141101.0456 c++ filt: Plasma::Applet::destroyedChanged(bool) Looking at master it was replaced with new code ( in my research it was removed to workaround on textarea input breaking) But our current tar remains with it removed completely and so I need to know if this is an ABI break or do we have the wrong tar? I have attached the diff between master -> our current tar. Please if anyone can assist me here. Thanks! Scarlett -- Scarlett Clark Kubuntu Developer KDE Contributor IRC: sgclark Email: [email protected]
--- src/scriptengines/qml/plasmoid/appletinterface.cpp 2014-11-05 16:15:31.892416716 -0800
+++ /home/scarlett/Work/ppa-source/plasma-framework-5.4.0/src/scriptengines/qml/plasmoid/appletinterface.cpp 2014-11-02 04:58:07.000000000 -0800
@@ -59,8 +59,7 @@
m_appletScriptEngine(script),
m_backgroundHints(Plasma::Types::StandardBackground),
m_busy(false),
- m_hideOnDeactivate(true),
- m_positionBeforeRemoval(QPointF(-1, -1))
+ m_hideOnDeactivate(true)
{
qmlRegisterType<QAction>();
@@ -73,10 +72,6 @@
connect(applet(), &Plasma::Applet::statusChanged,
this, &AppletInterface::statusChanged);
-
- connect(applet(), &Plasma::Applet::destroyedChanged,
- this, &AppletInterface::destroyedChanged);
-
connect(applet(), &Plasma::Applet::activated,
this, &AppletInterface::activated);
@@ -129,9 +124,6 @@
connect(applet(), &Plasma::Applet::statusChanged,
this, &AppletInterface::statusChanged);
- connect(applet(), &Plasma::Applet::destroyedChanged,
- this, &AppletInterface::destroyedChanged);
-
connect(appletScript(), &DeclarativeAppletScript::formFactorChanged,
this, &AppletInterface::formFactorChanged);
connect(appletScript(), &DeclarativeAppletScript::locationChanged,
@@ -183,38 +175,6 @@
}
}
-void AppletInterface::destroyedChanged(bool destroyed)
-{
- //if an item loses its scene before losing the focus, will never
- //be able to gain focus again
- if (destroyed && window() && window()->activeFocusItem()) {
- QQuickItem *focus = window()->activeFocusItem();
- QQuickItem *candidate = focus;
- bool isAncestor = false;
-
- //search if the current focus item is a child or grandchild of the applet
- while (candidate) {
- if (candidate == this) {
- isAncestor = true;
- break;
- }
- candidate = candidate->parentItem();
- }
-
- if (isAncestor) {
- //Found? remove focus for the whole hierachy
- candidate = focus;
-
- while (candidate && candidate != this) {
- candidate->setFocus(false);
- candidate = candidate->parentItem();
- }
- }
- }
-
- setVisible(!destroyed);
-}
-
Plasma::Types::FormFactor AppletInterface::formFactor() const
{
return applet()->formFactor();
signature.asc
Description: This is a digitally signed message part.
-- kubuntu-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel
