----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122023/#review73906 -----------------------------------------------------------
Ship it! src/package.cpp <https://git.reviewboard.kde.org/r/122023/#comment51380> That probably needs to use ::fromUtf8 because of [1]. And with that said, I think origin actually should be changed to fromUtf8 as well if you find a minute. AFAIK there is no encoding limitiation on apt Release files, so what comes out of apt-pkg could very well be !latin for origin as well. [1] http://en.wikipedia.org/wiki/Internationalized_domain_name - Harald Sitter On Jan. 13, 2015, 2:53 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122023/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 2:53 a.m.) > > > Review request for Kubuntu, Michael Stemle and Harald Sitter. > > > Repository: libqapt > > > Description > ------- > > This exposes public API in apt, to QApt. Quite straightforward. > > The reason for needing this is that the filtering we're doing currently by > Origin name is quite broken and I'd like to use the "Site" property. > > > Diffs > ----- > > src/package.h 19c5f19 > src/package.cpp fe58e1b > > Diff: https://git.reviewboard.kde.org/r/122023/diff/ > > > Testing > ------- > > Not much, builds, can be called. > > > Thanks, > > Aleix Pol Gonzalez > >
-- kubuntu-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel
