----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122777/#review76951 -----------------------------------------------------------
Ship it! Looks good at a glance to separate phononexperimental, compiles and kmix compiles against it fine - Jonathan Riddell On March 2, 2015, 4:09 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122777/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 4:09 p.m.) > > > Review request for Kubuntu, Phonon, Rohan Garg, Jonathan Riddell, and Sune > Vuorela. > > > Repository: phonon > > > Description > ------- > > This allows two things > a) One can build with experimental but not have it installed when building > libphonon software which helps Debian. > b) A config consumer can now specify experimental as COMPONENT and force > the phonon config to look for experimental and butt out when it can't > find it. Whereas previously the consumer would have to check the > variables we set to check whether experimental is even available. > > Additionally we continue to quietly look for experimental when it was > built. We do now ignore if it wasn't found thus enabling our builds > to have created experimental but have it not necessarily be available at > buildtime of a consumer. > > This is presenting a **slight** incompatibility in that consumers that > did previously not check our variables for whether experimental is > available (i.e. simply assumed it is always available) will now fail iff > the experimental config is not present when building the consumer. > Obviously the consumers did not necessarily build in all setups (i.e. those > without experimental) previously anyway, this is really not much of a > concern however. > > > Diffs > ----- > > CMakeLists.txt 003e453349d61c6468d7a1111f3d95cd870cdeb7 > PhononConfig.cmake.in 02f8b9aa29b865566536fc0fcb7a425ac09c0cfc > PhononExperimentalConfig.cmake.in PRE-CREATION > PhononExperimentalConfigVersion.cmake.in PRE-CREATION > phonon/experimental/CMakeLists.txt a70366490958dd89631787b1a0cf90033a93b85d > > Diff: https://git.reviewboard.kde.org/r/122777/diff/ > > > Testing > ------- > > built, consumed, exploded > > > Thanks, > > Harald Sitter > >
-- kubuntu-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel
