gotcha thanks, applied
On Mon, Jun 15, 2015 at 07:46:16AM +0200, José Manuel Santamaría Lema wrote: > Hi Jonathan, > > Jonathan Riddell <[email protected]> > > On Sun, Jun 14, 2015 at 09:03:10PM +0200, José Manuel Santamaría Lema wrote: > [snip] > > > * plasma-package-names - Don't ask for baloo version, print error message > > > if the number of arguments is wrong > > > > why not? > > Because doing that means having more code in the script and because not > asking > for the baloo version makes the script easier to use in my opinion; this way > we don't have to find out the baloo version, which, unlike the general plasma > version, is more prone to be forgotten. > > Also note that the way the script is done now, if you type this arguments > "5.3.1 2" (wrong baloo version) baloo and some other packages are silently > discarded from the list, and this isn't something desirable in my book. > > Allright, they aren't huge problems, but I still think it's better with the > patch. > > > > * kdeapplications-package-names - Don't ask for kdepim version > > > > why not? > > Same as above. > -- > kubuntu-devel mailing list > [email protected] > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel -- kubuntu-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel
