> On March 2, 2016, 11:58 a.m., Aleix Pol Gonzalez wrote: > > Then remove canExit altogether from QAptActions.
yes, that's in the patch, or did I miss it somewhere? (grep finds nothing) I could remove queryClose altogether or make the quit signal call it, so that the behaviour of Ctrl+Q and Alt+F4 will be consistent. As of now one does the check before exiting, but the other one doesn't. Then, maybe, the backend will eventually get its own implementation of canExit. - Carlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127249/#review93066 ----------------------------------------------------------- On March 2, 2016, 9:34 a.m., Carlo Vanini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127249/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 9:34 a.m.) > > > Review request for Kubuntu and Muon Package Management Suite. > > > Bugs: 358659 > http://bugs.kde.org/show_bug.cgi?id=358659 > > > Repository: muon > > > Description > ------- > > The variable m_canExit was not initialized and did prevent muon from exiting > when closed from the window manager. Remove it because it is never changed > and remove canExit() because it is in the wrong place anyway to prevent > exiting while acting on packages. It should be in backend. > > > Diffs > ----- > > src/MainWindow.cpp 466ea4bc00773dbd5353a477a10bbb125d021287 > src/muonapt/QAptActions.h 33db6e19d1a1a7bed3d15c8a33cabe51242d661c > > Diff: https://git.reviewboard.kde.org/r/127249/diff/ > > > Testing > ------- > > * open muon > * close by clicking the X button in the window decoration or with Alt+F4 > > Closing with File -> Exit or Ctrl+Q does not call MainWindow::queryClose() > and therefore di always work. > > > Thanks, > > Carlo Vanini > >
-- kubuntu-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel
