repository: /home/avi/kvm/linux-2.6
branch: avoid-spurious-edge-irq
commit faba110779451794f764a4802e740146e8efb93f
Author: Avi Kivity <[EMAIL PROTECTED]>
Date: Wed Sep 19 15:48:58 2007 +0200
KVM: Avoid redelivery of edge-triggered irq if it is already in service
Noticed by Eddie Dong.
Signed-off-by: Avi Kivity <[EMAIL PROTECTED]>
diff --git a/drivers/kvm/ioapic.c b/drivers/kvm/ioapic.c
index fa6f9d6..91ce92d 100644
--- a/drivers/kvm/ioapic.c
+++ b/drivers/kvm/ioapic.c
@@ -237,6 +237,7 @@ static void ioapic_deliver(struct kvm_ioapic *ioapic, int
irq)
void kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
{
+ u32 old_irr = ioapic->irr;
u32 mask = 1 << irq;
union ioapic_redir_entry entry;
@@ -246,7 +247,8 @@ void kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq,
int level)
ioapic->irr &= ~mask;
else {
ioapic->irr |= mask;
- if (!entry.fields.trig_mode || !entry.fields.remote_irr)
+ if ((!entry.fields.trig_mode && old_irr != ioapic->irr)
+ || !entry.fields.remote_irr)
ioapic_service(ioapic, irq);
}
}
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-commits mailing list
kvm-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-commits
