Christoph Hellwig wrote: > On Mon, Nov 27, 2006 at 12:29:38PM -0000, Avi Kivity wrote: > >> #ifdef __x86_64__ >> - __set_efer(vcpu, sregs->efer); >> + kvm_arch_ops->set_efer(vcpu, sregs->efer); >> #endif >> > > I think it would be much better to make ->set_efer a noop for 32bit, > and have different operation vectors for 32 vs 64 bit. > >
Okay. I'll submit an incremental patch as part of a larger cleanup I'm planning. >> #ifdef __x86_64__ >> - __set_efer(vcpu, 0); >> + vmx_set_efer(vcpu, 0); >> #endif >> > > Similarly vmx_set_efer should just become a noop on 32bit. > Ok. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
