Ingo Oeser wrote: > Hi, > > On Thursday, 28. December 2006 11:11, Avi Kivity wrote: > >> Index: linux-2.6/drivers/kvm/svm.c >> =================================================================== >> --- linux-2.6.orig/drivers/kvm/svm.c >> +++ linux-2.6/drivers/kvm/svm.c >> @@ -1068,6 +1068,9 @@ static int emulate_on_interception(struc >> static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data) >> { >> switch (ecx) { >> + case 0xc0010010: /* SYSCFG */ >> + case 0xc0010015: /* HWCR */ >> + case MSR_IA32_PLATFORM_ID: >> case MSR_IA32_P5_MC_ADDR: >> case MSR_IA32_P5_MC_TYPE: >> case MSR_IA32_MC0_CTL: >> > > What about just defining constants for these? > Then you can rip out these comments. > > Same for linux-2.6/drivers/kvm/vmx.c >
Yes, there are a few more of these as well. I'll clean them up once things quiet down a bit. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel