Rafael J. Wysocki wrote: > On Tuesday, 30 January 2007 22:20, Nigel Cunningham wrote: > >> Hi. >> >> On Tue, 2007-01-30 at 14:57 +0000, Avi Kivity wrote: >> >>> Add the necessary callbacks to suspend and resume a host running kvm. This >>> is just a repeat of the cpu hotplug/unplug work. >>> >>> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> >>> >> Maybe it's just a lack of understanding, but I'm wondering if this patch >> is necessary - we already hot-unplug secondary cpus prior to suspending >> devices. >> > >
The on_each_cpu() in the patch really means on_this_cpu(). > Not with the reoredering patches that are in -mm, though. With these patches, > the nonboot CPUs are disabled after "regular" devices. > After that, it means on_each_cpu() again, and the hotplug patch becomes unnecessary (except to support hotplug, of course). Assuming I understand things correctly, which if not at all certain. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel
