On Tue, Feb 20, 2007 at 09:46:17AM +0200, Avi Kivity wrote:
> Muli Ben-Yehuda wrote:
> >Thanks for the analysis, this problem is understood. Avi commited a
> >fix for -14 a few days back, but the fix re-breaks
> >--kerneldir. Reenabling --kerneldir is simple - see attached patch -
> >but since this is obviously a fragile area, I decided not to push for
> >its inclusion. Maybe I'm the sole --kerneldir user :-)
> >
> >  
> 
> I want --kerneldir to work; but as you say the build stuff is 
> ridiculously fragile.
> 
> How was this tested?

I used this simple script to compare vanilla and patched and verified
the output is the same:

onebuild ()
{
    ./configure --qemu-cc=gcc-3.4 $1 && echo "XXX configure done" && (cd kernel 
&& make LINUX=~/kvm/linux-2.6 sync) && make
    echo "XXX installing..."
    sudo make install
    echo "XXX cleaning"
    make clean
}

make clean
onebuild --kerneldir=/home/muli/iommu/calgary/obj.linux/
onebuild --kerneldir=/lib/modules/`uname -r`/build
onebuild

The patch I used is this one:

Index: kernel/Makefile
===================================================================
--- kernel/Makefile     (revision 4461)
+++ kernel/Makefile     (working copy)
@@ -1,4 +1,5 @@
-KERNELDIR := /lib/modules/$(shell uname -r)/build
+include ../config.mak
+
 KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
 
 DESTDIR=
Index: configure
===================================================================
--- configure   (revision 4461)
+++ configure   (working copy)
@@ -94,7 +94,7 @@
 
 cat <<EOF > config.mak
 PREFIX=$prefix
-KERNELDIR=$(readlink -f $kerneldir)
+KERNELDIR=$kerneldir
 WANT_MODULE=$want_module
 EOF
 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
kvm-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to