Joerg Roedel wrote: > On Thu, Feb 22, 2007 at 02:17:54AM -0800, Dor Laor wrote: > >> I have Ingo's network PV hypercalls to commit in my piplien. >> Till then we can just add the test hypercall: >> case __NR_hypercall_test: >> printk(KERN_DEBUG "%s __NR_hypercall_test\n", >> __FUNCTION__); >> ret = 0x5a5a; >> break; >> default: >> BUG(); >> > > Is it a good idea to call BUG() on an undefined hypercall? I assume its > better to inform the guest that is has issued an illegal call... > >
The code returns -KVM_EINVAL if the hypercall is not handled (and BUG() on the host as a response to something controlled by a guest is not a good idea). -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
