Ingo Molnar wrote: > * Avi Kivity <[EMAIL PROTECTED]> wrote: > > >>>> Won't that increase task_struct (16 bytes on 64-bit) unnecessarily? >>>> The function pointers are common to all virtual machines. >>>> >>> well, this function pointer could then be reused by other virtual >>> machines as well, couldnt it? >>> >> I don't get this. If we add a couple of members to task_struct, it >> can't be reused. The values will be the same across all tasks, but >> the memory will be gone (including tasks which aren't virtual >> machines). >> > > i mean, the function pointer is set by KVM, but it could be set to a > different value by other hypervisors. > >
What other hypervisors? ;-) Oh, if Rusty wants it for lguest I can put a pointer or a chain into task_struct. But I doubt it -- with paravirtualization there are no costly new registers to swap. > but ... no strong feelings either way, your patch is certainly fine. > > Acked-by: Ingo Molnar <[EMAIL PROTECTED]> > Thanks! -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
