On Tue, 10 Jul 2007, Avi Kivity wrote:

> Robert P. J. Day wrote:
> > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
> >
> > ---
> >
> >   just a trivial cosmetic fix, taking advantage of the static inlines
> > defined in include/linux/highmem.h.
> >
> > diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c
> > index c1ac106..6425084 100644
> > --- a/drivers/kvm/vmx.c
> > +++ b/drivers/kvm/vmx.c
> > @@ -1022,9 +1022,7 @@ static int init_rmode_tss(struct kvm* kvm)
> >     *(u16*)(page + 0x66) = TSS_BASE_SIZE + TSS_REDIRECTION_SIZE;
> >     kunmap_atomic(page, KM_USER0);
> >
> > -   page = kmap_atomic(p2, KM_USER0);
> > -   memset(page, 0, PAGE_SIZE);
> > -   kunmap_atomic(page, KM_USER0);
> > +   clear_highpage(p2);
> >
> >     page = kmap_atomic(p3, KM_USER0);
> >     memset(page, 0, PAGE_SIZE);
> >
>
> Git really doesn't want to apply this for some reason.  No idea why
> (the code hasn't changed).  Can you rebase this against kvm.git?
>
> Also, it's a bit pointless since we happily kmap immediately above
> and below.

actually, you're right, it *is* kind of pointless to do one cleanup in
the midst of a couple other calls that have to remain as they are, so
let's just forget that.  carry on.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to