Linus Torvalds wrote: > On Sat, 14 Jul 2007, Avi Kivity wrote: > >> Linus, please do your usual thing from the repository and branch at >> > > It has code like > > + /* Can deadlock when called with interrupts disabled */ > + WARN_ON(irqs_disabled()); > + > /* prevent preemption and reschedule on another processor */ > int me = get_cpu(); > > which is against the coding conventions (and shouldn't even compile > cleanly - but maybe we don't have the "warn about C99 variable > declarations" thng on?). >
It's on. I guess I didn't notice because other changes triggered a recompile of the whole tree. > Please don't do that. > Fixed and rebased. I also silenced a few warnings on the UP case by adding a missing #include. It's at the same place: git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
