Rusty Russell wrote: > On Tue, 2007-07-17 at 16:25 +0300, Avi Kivity wrote: > >> Rusty Russell wrote: >> >>> Creating one's own BITMAP macro seems suboptimal: if we use manual >>> arithmetic in the one place exposed to userspace, we can use standard >>> macros elsewhere. >>> >>> The - 7 + 8 calc is overkill: can NR_IRQ_WORDS ever really change? >>> >>> >> Looks like it can: >> > > Sure, but the number 256 is part of the x86 architecture. A paravirt > guest could choose to have more interrupts, but is there really a point? > >
I meant that you yourself, Rusty Russell, extended it to 2048 with your arithmetic. Sorry for being unclear. > Doh, fixed here: > == > Use standard BITMAP macros, open-code userspace-exposed header. > > Creating one's own BITMAP macro seems suboptimal: if we use manual > arithmetic in the one place exposed to userspace, we can use standard > macros elsewhere. > > Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
