On Tue, 2007-07-24 at 14:01 +0300, Avi Kivity wrote: > Rusty Russell wrote: > > KVM *will* be used to run malicious guests. That's going to be hard to > > lock down later, so I figure we should start now. > > There's no reason to make this KERN_WARN. There's nothing wrong with > the host, and there may not be anything wrong with the guest. These are > only used to see if the guest did something unexpected, which may or may > not be a problem (a kvm test suite would certainly trigger them). > > Perhaps we should make them conditional on a debug flag, or remove them > completely. Most of them don't ever trigger, and i don't expect we can > bring up a new guest solely using these printks.
So should there be two routines? pr_unimpl() (KERN_ERR) and pr_unexpected() (KERN_DEBUG) maybe. Both ratelimited, with nice formatting to tell user which machine & cpu for reporting when there's a problem... Turning them off is your call: have they proven useful? Thanks, Rusty. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
