On Tue, 2007-08-14 at 12:43 +0530, Amit Shah wrote: > On Tuesday 14 August 2007 09:37:45 Gregory Haskins wrote:
> There are several things about this patch which aren't nice: > - It implicitly does a kmap_atomic. That's a bad thing for procedures that > might sleep after calling this > - It's prone to not being kunmapped > - kmap_atomic takes two arguments > - 'page' is not checked for !NULL > - we can simply use gpa_to_hpa and get page_address(hpa), instead of > duplicating all that it does. > You are probably right on all accounts. I am not an expert in this area and have been getting help from Hollis and Anthony via IRC. There is a very good chance I have misunderstood some of their extremely helpful pointers to me. -Greg ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel
