OK to me. 
Thanks.

Yang, Sheng
>-----Original Message-----
>From: [EMAIL PROTECTED]
>[mailto:[EMAIL PROTECTED] On Behalf Of Glauber de
>Oliveira Costa
>Sent: 2007年8月15日 2:55
>To: Avi Kivity
>Cc: kvm-devel@lists.sourceforge.net; (अमेय) Ameya (पाळंदे) Palande
>Subject: Re: [kvm-devel] Error while inserting kvm-intel.ko from kvm-34
>
>> >
>>  I got the same behaviour here, and it seems that the reason is 32-bit
>> machines does not use the CR8 register. But the code in vmx.c makes it
>> a minimum requirement as in:
>>
>>         min = CPU_BASED_HLT_EXITING |
>>               CPU_BASED_CR8_LOAD_EXITING |
>>               CPU_BASED_CR8_STORE_EXITING |
>>               CPU_BASED_USE_IO_BITMAPS |
>>               CPU_BASED_MOV_DR_EXITING |
>>               CPU_BASED_USE_TSC_OFFSETING;
>>
>> I think the solution is to enclose the CR8 constants in a ifdef
>> CONFIG_X86_64, since putting them as optional won't do the right thing
>> in 64-bit (and thus, core duo), machines.
>>
>> I was about to post a patch for it now.
>>
>> Avi, if you agree with the fix, I can do it right now.
>>
>
>BTW, in case you agree, here is the patch
>
>--
>Glauber de Oliveira Costa.
>"Free as in Freedom"
>http://glommer.net
>
>"The less confident you are, the more serious you have to act."
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to