Avi,
In my opinion converting this small function to file-scope function,
would make code look ugly. I think the earlier Macro definition was
better.
On Thu, 2007-08-16 at 03:25 -0700, Avi Kivity wrote:
> > + inline void jmp_rel(int rel)
> > + {
> > + _eip += (int)(rel);
> > + _eip = ((op_bytes == 2) ? (uint16_t)_eip :
> (uint32_t)_eip);
> > + };
> > +
>
> This is a nested function which we don't use (in the kernel or
> userspace).
>
> It needs to be a file-scope function (static, too).
--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-----------------------------------------------------------------
The mind is like a parachute; it works much better when it's open
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
