>-----Original Message----- >From: Avi Kivity [mailto:[EMAIL PROTECTED] >Sent: 2007年9月3日 22:22 >To: He, Qing >Cc: [email protected] >Subject: Re: [kvm-devel] [RFC][PATCH 0/7] guest SMP with in-kernel APIC > >He, Qing wrote: >> Hi, >> >> This patch set enables guest SMP when using in-kernel APIC. It is >> independent from the partial kernel apic SMP patch from Avi. We are >> posting it here for comments and possible merging with that patch. The >> patch set is based on: >> KVM: lapic5 branch: e9ddfaf472 (Remove dead code) with a patch >> that undoes 34735648ce (apic: implement init/sipi, work in progress), >> see the attachment in [PATCH 0/7]. >> kvm-userspace: lapic5 branch: 206d1aa22f (qemu: prevent set >> wrong cr8 when using irqchip). >> >> btw, I can't find the cr8 patch in kvm-userspace from kvm-userspace.git, >> but it is in kvm-commits mailing list. Is there anything happened when >> kvm-userspace relocates on kernel.org or am I missing anything? >> >> The patch set is: >> [PATCH 0/7] :this post, and a temporary sipi/init undo patch >> [PATCH 1/7] is a preparation patch for userspace >> [PATCH 2/7] and [PATCH 3/7] are bug fixes for kernel >> [PATCH 4/7] modifies the PIC interrupt routing for SMP >> [PATCH 5/7] enables round robin for the apic lowest priority >> delivery >> [PATCH 6/7] is the main patch for SMP support. It handles >> SIPI/INIT in the kernel >> [PATCH 7/7] is the usermode part for SMP support, which disables >> userleve SIPI/INIT handling >> >> >> I have tested some situation, 32bit SMP Windows xp/srv2k3 and Linux >> 2.6.9/2.6.18 all works fine using in-kernel apics. User mode APICs also >> works fine. Test for other environments is ongoing. >> >> [PATCH 6/7] and [PATCH 7/7] have additional comments, please see the >> corresponding post. >> > >Applied all to lapic6 (with minor style modification). Did not apply >the bios change; will do it later through cmos nvram. > >I will do some folding later on (will try out git rebase --interactive) >and merge to master.
Avi,
During the rebase to lapic6, I saw two patches missing in this branch.
Please see the attachments.
For the p1 patch, it was Sheng's patch to fix x86_64 windows booting. I
believe the commit 948a4b9e4b in kernel side (disable tpr/cr8 sync when
in-kernel APIC is used) also addresses this issue, but from code point of view,
this user mode patch is just OK, I see no reason to remove it. (btw., my
original update on the patch is unnecessary, you can just drop that update).
For the p2 patch, it was applied by you, and it's necessary for kernel
apic SMP. Please reapply it to lapic6, and it can be folded and merged with
kvm-userspace commit 314694c464 (conditionally bypass user level init/sipi
handling).
There is also a regression on SMP introduced by hrtimer migration. We
are currently working on it and will send it out later as separate patch set.
Thanks,
Qing
>
>--
>error compiling committee.c: too many arguments to function
p2-qemu-no-halted-mask-in-user.patch
Description: p2-qemu-no-halted-mask-in-user.patch
p1-qemu-no-cr8-sync-kernapic.patch
Description: p1-qemu-no-cr8-sync-kernapic.patch
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel
