Nick Piggin wrote: > On Tuesday 18 September 2007 04:19, Avi Kivity wrote: > >> Nick Piggin wrote: >> >>>> I should mention that the converting to use ->fault() is a 15-minute >>>> change; the tricky part is adding backwards compatibility for the >>>> external module package. >>>> >>> It should be mostly possible to ifdef a nopage() handler, which is >>> just a wrapper function to translate arguments then call your new >>> ->fault() handler. With luck, fault would mostly inline into nopage, >>> and do some constant folding to make it cheaper... >>> >>> I'm planning to go through and convert the rest of the in-tree users >>> at some point soon, so if you do get a chance to convert your >>> upstream code before I try, it would nice ;) >>> >> In kvm I don't add compatibility #ifdefs to mainline, instead I have an >> awk script that massages the sources into something that all kernels can >> grok. >> > > Sure, but my suggestion is just a way to make it possible without having > to maintain a lot of duplicated code. The point is simply that we'll be > getting rid of nopage from mainline sooner or later, and it will probably > be less painful for your out of tree stuff if you do it rather than me. Maybe. > >
Certainly it's best done by someone familiar with the kvm external module hackery. I'll do it during 2.6.24 if no one beats me to it. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel
