Jerone Young wrote:
> This patch makes things better for cross compiling. It also makes adding
> a new architecture to the current make system much easier.
>   

> +CFLAGS += -I $(KERNELDIR)/include $(autodepend-flags) -g 
> -fomit-frame-pointer \
> +     -Wall
> +CFLAGS += -m32
> +CFLAGS += -m64
>   

Nowhere is CFLAGS defined, that I can see.  This means that a stray 
CFLAGS environment variable will affect the build (this is the cause of 
my dislike to ?= as well).

Please change so that make variables cannot be affected by the environment.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to