On Thu, 2007-10-18 at 15:28 -0500, Anthony Liguori wrote: > Jerone Young wrote: > > This patch splits kvmctl architecture specific declarations & > > implementations into their own files & headers. Common interfaces are > > kept in kvmctl.h, as well as the arch specific headers are included from > > within kvmctl.h. This may or may not want to be changed. > > > > Also includes the having different main.c files for different > > architectures (otherwise it's a lot of ifdefs). > > > > Signed-off-by: Christian Ehrhardt <[EMAIL PROTECTED]> > > Signed-off-by: Jerone Young <[EMAIL PROTECTED]> > > > > This patch is pretty hard to reasonably review since diff is so large.
Yeah.. I'm going to break it down to try and make it more reviewable. > > A quick glance suggests that there's a lot of code duplication between > things like main-x86.c and main-ppc.c. Perhaps the common code could be > unified? I do have a main.c with ifdefs. But the feeling here is that as things are added this gets hair really quick. Right now it's ok with only 2 main architectures. But if others come in, this file could turn into an ifdef mess. I really have no strong feelings on it. I can combine them. > > Regards, > > Anthony Liguori > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel
