Nitin A Kamble wrote: > Hi Avi, > Attached is the patch to implement mul instruction from the group 3 > opcodes. > > diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c > index 3959c20..5815128 100644 > --- a/drivers/kvm/x86_emulate.c > +++ b/drivers/kvm/x86_emulate.c > @@ -1034,6 +1034,8 @@ static inline int emulate_grp3(struct > x86_emulate_ctxt *ctxt, > case 3: /* neg */ > emulate_1op("neg", c->dst, ctxt->eflags); > break; > + case 4: /* mul */ > + emulate_1op("mul", c->dst, ctxt->eflags); > default: > DPRINTF("Cannot emulate %02x\n", c->b); > rc = X86EMUL_UNHANDLEABLE;
This is missing a "break;". How are you testing these patches? -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel