On Wed, 2007-10-31 at 12:05 -0500, Jerone Young wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1193849563 18000 > # Node ID 19a7c6d2ddfd1383aeb8a9bc09d9fe0673e7f9cc > # Parent c3d6e1e2b8a0368485badcde0e55a82d9b1897d1 > Move kvm_context to kvmctl.h > > This patch moves kvm_context from kvmctl.c to kvmctl.h. This is so > other files are able to see members of kvm_context. Also you should > allways declare stuff like this in a header anyway. Also moved are > delcrations MAX_VCPU & KVM_MAX_NUM_MEM_REGIONS to kvmctl-x86.h. As these > are closely associated with the architecture. > > Signed-off-by: Jerone Young <[EMAIL PROTECTED]> > > diff --git a/libkvm/Makefile b/libkvm/Makefile > --- a/libkvm/Makefile > +++ b/libkvm/Makefile > @@ -21,7 +21,7 @@ autodepend-flags = -MMD -MF $(dir $*).$( > > all: libkvm.a > > -libkvm.a: libkvm.o > +libkvm.a: libkvm.o $(libkvm-$(ARCH)-objs) > $(AR) rcs $@ $^ > > install: > diff --git a/libkvm/config-i386.mak b/libkvm/config-i386.mak > --- a/libkvm/config-i386.mak > +++ b/libkvm/config-i386.mak > @@ -1,2 +1,3 @@ > +libkvm-$(ARCH)-objs := libkvm-x86.o > > LIBDIR := /lib
This patch does not create libkvm-x86.o. > diff --git a/libkvm/libkvm-x86.h b/libkvm/libkvm-x86.h > new file mode 100644 > --- /dev/null > +++ b/libkvm/libkvm-x86.h > @@ -0,0 +1,7 @@ > +#ifndef KVMCTL_X86_H > +#define KVMCTL_X86_H > + > +#define KVM_MAX_NUM_MEM_REGIONS 8u > +#define MAX_VCPUS 4 > + > +#endif I'm not sure this is needed. Since there may be other intra-patch logical discrepancies, it might be best for reviewers to apply all at once and then examine the final result, rather than trying to read and comment on each individual patch. -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
