Izik Eidus wrote: > On Thu, 2007-11-22 at 11:25 +0800, Zhang, Xiantao wrote: >> From: Zhang Xiantao <[EMAIL PROTECTED]> >> Date: Thu, 22 Nov 2007 11:20:33 +0800 >> Subject: [PATCH] KVM Portability: moving unalias_gfn to arch. >> Non-x86 archs don't need this mechanism. Move it to arch, and keep >> its interface in common. Signed-off-by: Zhang Xiantao >> <[EMAIL PROTECTED]> --- > > this is good, > > we probably want to change > gfn_to_memslot() to have #ifdef kvm_x86 to call the unalias memory > and gfn_to_hva on x86 still must to call unalias_gfn() so it will > probably need a ifdef as well.
Don't know #ifdef way is acceptable. If yes, sure to do that. Contrarily, other archs can define it , and just returen original gfn instead:) > ------------------------------------------------------------------------ - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2005. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > kvm-devel mailing list > kvm-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/kvm-devel ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
