Cornelia Huck wrote: >> Carsten Otte wrote: >> >>> This patch removes the include of "irq.h" in kvm_main.c, s390 does not >>> have irqs. For that, kvm_cpu_has_interrupt becomes an architecutre >>> specific function which can check for external or I/O interrupts on s390 >>> and for irqs on x86 and others. In order to clarify wording, the >>> function defined by irq.h has been renamed to kvm_cpu_has_irq. >>> >>> >> I generally understand "irq" to mean the interrupt request line, and >> "interrupt" to mean a vectored interrupt (post interrupt controller). >> In those terms the naming in correct. However I'm not at all certain >> this naming convention is generally accepted. >> > > Well, at least IO-Interrupts on s390 don't really fit this model from my > point of view. (In fact, we can even get IO-Interrupts that are not > associated with any (channel) device at all). >
Oh, I agree about the removal, just wondering about the name change. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel