Jerone Young wrote: > Actually this is was probably way overkill on moving these. I don't > think that this patch is really needed. So I say just leave it be. > Since they are macros they really cause no harm being where they are. > It's also easier to make sure that none collide on the numbers they > use.
Since it is in common code, maybe we should use CONFIG_X86 marco to handle it, and it won't lead to unnecessary definitions for all archs and also allows other archs to define their arch-specific ioctls. Certaninly, I don't think we can split them, since they are numbered in sequence, and can't change considering compability issue. Xiantao > On Fri, 2007-11-30 at 11:49 +0200, Avi Kivity wrote: >> Jerone Young wrote: >>> This patch is a continuation of the 7 patches sent earlier. This >>> patch moves all x86 specific macros from include/linux/kvm.h to >>> include/asm-x86/kvm.h. >>> >>> >> >> Just noticed I'd dropped this old patch. Unfortunately kvm.git has >> changed in this area. Care to re-spin? >> >> Sorry about the drop. >> > > > ------------------------------------------------------------------------ - > SF.Net email is sponsored by: The Future of Linux Business White Paper > from Novell. From the desktop to the data center, Linux is going > mainstream. Let it simplify your IT future. > http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 > _______________________________________________ > kvm-devel mailing list > kvm-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/kvm-devel ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
