Amit Shah wrote: > On Thursday 27 December 2007 13:20:06 Zhang, Xiantao wrote: > >>>> It shouldn't have any confilicts, since they belong to different >>>> archs. Currently, you know source code is placed at >>>> arch/{$arch}/kvm, and Makefile and Kconfig aslo there. >>>> So, it doesn't impact any issues, since ia64 and x86_64 are totally >>>> different archs. For example, you can define HAS_IO_PORT macro for >>>> ia64 and x86, but they don't invoke any conficlts.:) >>>> >>> What about files that get shared? >>> >> I think common files shouldn't use KVM_CONFIG_INTEL. >> > > Even then I'm not sure we should use a common #define within the sources that > will apply to two different architectures in different ways under different > build environments. Avi, what do you think? >
I agree in principle, but I don't see a big hurry to change things. Let's get it merged first. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel