Jan Kiszka wrote: > Jan Kiszka wrote: > >> At this chance, can anyone comment on these uint32_t types? >> >> static int subpage_register (subpage_t *mmio, uint32_t start, uint32_t end, >> int memory); >> static void *subpage_init (target_phys_addr_t base, uint32_t *phys, >> int orig_memory); >> >> Shouldn't they be target_phys_addr_t? Can't this cause troubles when >> building 64-bit targets? Looks like it's even a generic qemu issue. >> > > At least it should cause no harm to convert to target_phys_addr_t, so > here is a cleanup patch for qemu/exec.c. > >
Please post these patches to qemu-devel, in order to limit the divergence between kvm's version of qemu and upstream. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
