Anthony Liguori wrote:
> This patch attempts to clean up the interactions between KVM and
> QEMU.  Sorry 
> for such a big patch, but I don't think there's a better way to
> approach this 
> such that it's still bisect friendly.  I think this is most of what's
> needed to 
> get basic KVM support into QEMU though.
> 
> Right now, there's a mix of #ifdef USE_KVM, if (kvm_allowed), and
> various 
> extern declarations.  It's all pretty fugly and there's a lot of
> mistakes due 
> to it.
> 
> The following patch eliminates almost all uses of #ifdef USE_KVM by
> introducing 
> a kvm_enabled() macro.  If USE_KVM is set, this macro evaluates to
> kvm_allowed. 
> If USE_KVM isn't set, the macro evaluates to 0.
> 
> Since GCC eliminates if (0) blocks, this is just as good as using
> #ifdef.  By 
> making sure that we never call into libkvm directly from QEMU, we can
> also just 
> not link qemu-kvm when USE_KVM isn't set instead of having the entire
> file 
> wrapped in a USE_KVM.
> 
> We also change the --enable-kvm configure option to --disable-kvm
> since KVM is 
> enabled by default.
> 
> I've tested this patch on x86 with 32-bit and 64-bit Linux guests and
> a 32-bit 
> Windows guest.  I've also tested with USE_KVM not set.  Jerone has
> also 
> verified that it doesn't PPC.  My apologies if it breaks ia64 but I
> have no 
> way of testing that.

Hi, Anthony 
        Good patch indeed! I have checked ia64 side, and It shouldn't
break ia64. Thanks!
Xiantao

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to