Anders Melchiorsen wrote: > I am wondering about this commit, > > http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commit;h=b4e392c21c4b98c1c13af353caa3d6e6bcb6b8af > > which adds signals on tap I/O. It seems a bit half-done to me. For one > thing, it is mixing timers with I/O. > >
The signal handler doesn't actually matter; all that's needed is to break out of the loop. > Anyway, my question is about the remaining file descriptors. Should > signals be activated for them as well, for example in > qemu_set_fd_handler2() ? My example on hand is that connecting a VNC > client currently delays until the next timer expiry. In practice it doesn't matter, but yes, any fd which we will select() needs to have a signal attached. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
