Hi Avi,
Looks nice.
On Sun, Mar 02, 2008 at 06:31:17PM +0200, Avi Kivity wrote:
> +int kvm_pv_mmu_op(struct kvm_vcpu *vcpu, unsigned long bytes,
> + gpa_t addr, unsigned long *ret)
> +{
> + int r;
> + struct kvm_pv_mmu_op_buffer buffer;
Perhaps this structure is a little large to be on stack.
> + down_read(¤t->mm->mmap_sem);
> + down_read(&vcpu->kvm->slots_lock);
The order should be slots_locks then mmap_sem. Need some comment in the
code.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel
