Marcelo Tosatti wrote:
> Its necessary to guarantee that pending AIO writes have reached stable
> storage when the flush request returns.
>
> Also change fsync() to fdatasync(), since the modification time is not
> critical data.
> + if (aio_fsync(O_DSYNC, &acb->aiocb) < 0) {
> BDRVRawState *s = bs->opaque;
> - fsync(s->fd);
> + raw_aio_flush(bs);
> + fdatasync(s->fd);
> +
> + /* We rely on the fact that no other AIO will be submitted
> + * in parallel, but this should be fixed by per-device
> + * AIO queues when allowing multiple CPU's to process IO
> + * in QEMU.
> + */
> + qemu_aio_flush();
I'm a bit confused by this. Why do you need aio_fsync(O_DSYNC) _and_
synchronous fdatasync() calls? Aren't they equivalent?
-- Jamie
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
