Dor Laor wrote:
>
>> +static uint32_t vring_desc_len(VirtQueue *vq, unsigned int i)
>> +{
>
> Below there were place you did use offsetof(vq->vring.desc[i], len) so
> we better be consistent + its nicer
>
>> + return ldl_phys(vq->vring.desc + i * sizeof(VRingDesc) +
>> + offsetof(VRingDesc, len));
>> +}
>> +
Oh, this bit is different because you need to do offsetof(Type, member)
and vq->vring.desc[i] is not a type. It only works when you're doing an
array with member[X].
Regards,
Anthony Liguori
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
