On Sat, 2008-04-05 at 02:41 +0200, Andrea Arcangeli wrote: > On Fri, Apr 04, 2008 at 04:12:42PM -0700, Jeremy Fitzhardinge wrote: > > I think you can break this if() down a bit: > > > > if (!(vma->vm_file && vma->vm_file->f_mapping)) > > continue; > > It makes no difference at runtime, coding style preferences are quite > subjective.
I'll have to concurr with Jeremy here, please break that monstrous if stmt down. It might not matter to the compiler, but it sure as hell helps for anyone trying to understand/maintain the thing. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Register now and save $200. Hurry, offer ends at 11:59 p.m., Monday, April 7! Use priority code J8TLD2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
