Nguyen Anh Quynh wrote:
> This patch replaces the current assembly code of Extboot option rom
> with new C code. Patch is against kvm-66.
> 
> This version returns an error code in case int 13 handler cannot
> handle a requested function.
> 
> Signed-off-by: Nguyen Anh Quynh <[EMAIL PROTECTED]>
> 

+       /* -fomit-frame-pointer might clobber %ebp */
+       pushl %ebp
+       call setup
+       popl  %ebp


No, it might not.  %ebx, %ebp, %esi, and %edi are guaranteed preserved; 
%eax, %ecx and %edx are clobbered.

It's also prudent to call cld before jumping to C code.

        -hpa


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to