> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Hollis Blanchard > Sent: Tuesday, December 16, 2008 7:32 AM > To: Liu Yu-B13201 > Cc: [email protected] > Subject: Re: [PATCH 06/11] E500 instructions emulation > > On Thu, 2008-12-11 at 17:11 +0800, Liu Yu wrote: > > + > > +#define OP_RFI 19 > > + > > +#define XOP_RFI 50 > > +#define XOP_MFMSR 83 > > +#define XOP_WRTEE 131 > > +#define XOP_MTMSR 146 > > +#define XOP_WRTEEI 163 > > +#define XOP_TLBIVAX 786 > > +#define XOP_TLBSX 914 > > +#define XOP_TLBRE 946 > > +#define XOP_TLBWE 978 > > I'd prefer you use spaces for formatting (so that they look the same > regardless of tabstop size), but no matter what you should be > consistent > (see OP_RFI vs XOP_RFI). > > > +static void kvmppc_emul_rfi(struct kvm_vcpu *vcpu) > > +{ > > + vcpu->arch.pc = vcpu->arch.srr0; > > + kvmppc_set_msr(vcpu, vcpu->arch.srr1); > > +} > > Actually, right now I'm wondering why rfi emulation isn't in > the shared > emulation code. Do you see any core-specific issues there? Same with > wrtee* and m*msr.
Heh, I was curious why you split them. > > I bet I was thinking "we should have booke_emulate.c in the > future" when > I moved the 44x code. What do you think about that? > I think it's ok. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
