On 2012-02-06 19:25, Marcelo Tosatti wrote:
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index c38efd7..a1761ff 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -2252,7 +2252,6 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
>>              kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
>>              if (vcpu->cpu != cpu)
>>                      kvm_migrate_timers(vcpu);
>> -            vcpu->cpu = cpu;
>>      }
> 
> This is wrong, kvm_sched_in fails to see vcpu->cpu properly. Please
> keep vcpu->cpu assignment in arch code.

True, but then kvm_sched_in is a better place for this assignment (as
it's central), no?

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to