On 11.12.2013, at 00:11, Scott Wood <[email protected]> wrote:
> On Tue, 2013-12-10 at 03:05 +0100, Alexander Graf wrote: >> On 09.12.2013, at 22:18, Scott Wood <[email protected]> wrote: >> >>> On Mon, 2013-11-25 at 04:26 -0600, Bharat Bhushan wrote: >>>> >>>>> -----Original Message----- >>>>> From: Wood Scott-B07421 >>>>> Sent: Saturday, November 23, 2013 3:22 AM >>>>> To: Alexander Graf >>>>> Cc: [email protected]; [email protected]; Wood Scott-B07421; >>>>> Bhushan >>>>> Bharat-R65777 >>>>> Subject: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame >>>>> size >>>>> warning >>>>> >>>>> Commit ce11e48b7fdd256ec68b932a89b397a790566031 ("KVM: PPC: E500: Add >>>>> userspace debug stub support") added "struct thread_struct" to the >>>>> stack of kvmppc_vcpu_run(). thread_struct is 1152 bytes on my build, >>>>> compared to 48 bytes for the recently-introduced "struct debug_reg". >>>>> Use the latter instead. >>>>> >>>>> This fixes the following error: >>>>> >>>>> cc1: warnings being treated as errors >>>>> arch/powerpc/kvm/booke.c: In function 'kvmppc_vcpu_run': >>>>> arch/powerpc/kvm/booke.c:760:1: error: the frame size of 1424 bytes is >>>>> larger >>>>> than 1024 bytes >>>>> make[2]: *** [arch/powerpc/kvm/booke.o] Error 1 >>>>> make[1]: *** [arch/powerpc/kvm] Error 2 >>>>> make[1]: *** Waiting for unfinished jobs.... >>>>> >>>>> Signed-off-by: Scott Wood <[email protected]> >>>>> Cc: Bharat Bhushan <[email protected]> >>>>> --- >>>>> Build tested only. Bharat, please test. >>>> >>>> Tested with qemu debug stub; It works fine >>>> >>>> -Bharat >>> >>> Alex, are you going to take this through your tree? >> >> Sure. Do you want this for 3.13 or 3.14? Since I don't see the breakage >> with my compilers I'd queue it for 3.14, but whatever works for you >> works for me. > > 3.13 please. All I need to do to trigger the build break is enable KVM > with corenet64_smp_defconfig with GCC 4.5. Thanks, applied to the for-3.13 branch. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
