Hi Weidong,
Minor comments below.
On Mon, Jun 23, 2008 at 10:53:17PM +0800, Han, Weidong wrote:
> printk("kvm_iommu_map_guest: domain = %p\n",
> kvm->arch.domain);
> -
> +
This patch is line-wrapped, and there's some uneeded whitespace above.
> if (kvm_iommu_map_memslots(kvm)) {
> kvm_iommu_unmap_memslots(kvm);
> return -EFAULT;
> }
> - kvm_intel_iommu_context_mapping(kvm->arch.domain, pdev);
> +
> + if (kvm_intel_iommu_context_mapping(kvm->arch.domain, pdev)) {
> + printk(KERN_ERR "Domain context map for %s failed",
> + pci_name(pdev));
> + return -EFAULT;
> + }
Why not return the return value from kvm_intel_iommu_context_mapping()
directly? It will make debugging a little bit easier.
Cheers,
Muli
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
