On Sat, Jul 19, 2008 at 03:11:44PM -0300, Marcelo Tosatti wrote:
> 
> If a vcpu has been offlined, or not initialized at all, signals
> requesting userspace work to be performed will result in KVM attempting
> to re-entry guest mode.
> 
> Problem is that the in-kernel irqchip emulation happily executes HALTED
> state vcpu's. This breaks "savevm" on Windows SMP installation, for
> example.
> 
> Also, setting the mpstate to runnable when setting an IRQ via
> pic_irq_request / kvm_apic_set_irq is necessary due to this check on
> emulate_halt:
> 
>                 kvm_vcpu_block(vcpu);
>                 down_read(&vcpu->kvm->slots_lock);
>                 if (vcpu->arch.mp_state != KVM_MP_STATE_RUNNABLE)
>                         return -EINTR;
> 
> Otherwise the vcpu will return to userspace needlessly.

Scratch this, burns 100% CPU.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to