Am Dienstag, 29. Juli 2008 schrieb Christian Borntraeger:
> @@ -158,6 +158,7 @@ static int handle_stfl(struct kvm_vcpu *
>
> vcpu->stat.instruction_stfl++;
> facility_list &= ~(1UL<<24); /* no stfle */
> + facility_list &= ~(1UL<<23); /* no large pages */
>
> rc = copy_to_guest(vcpu, offsetof(struct _lowcore, stfl_fac_list),
> &facility_list, sizeof(facility_list));
Hello Avi,
please dont apply this patch, there is a better one...
Heiko pointed out, that its generally safer to use an opt-in method instead
of killing problematic cases.
What about this updated patch:
From: Christian Borntraeger <[EMAIL PROTECTED]>
Newer machine models can add new feature bits, which might require host
changes. We have to ensure that we only advertise feature flags which we
consider save. I disabled all unassigned feature flags, as well as stfle,
large pages and some others.
Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]>
---
arch/s390/kvm/priv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: kvm/arch/s390/kvm/priv.c
===================================================================
--- kvm.orig/arch/s390/kvm/priv.c
+++ kvm/arch/s390/kvm/priv.c
@@ -157,7 +157,8 @@ static int handle_stfl(struct kvm_vcpu *
int rc;
vcpu->stat.instruction_stfl++;
- facility_list &= ~(1UL<<24); /* no stfle */
+ /* only pass the facility bits, which we can handle */
+ facility_list &= 0xfe00fff3;
rc = copy_to_guest(vcpu, offsetof(struct _lowcore, stfl_fac_list),
&facility_list, sizeof(facility_list));
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
